Re: Log-1.7.0
| From: | Jon Parise | Date: | Thu, 18 Sep 2003 07:13:49 +0000 |
| Subject: | Re: Log-1.7.0 | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-21689@lists.php.net to get a copy of this message | ||
[Cc:'ing pear-dev so I won't have to repeat this there later should
other developers ask for my opinion on the matter.]
On Thu, Sep 18, 2003 at 08:55:25AM +0200, Pierre-Alain Joye wrote:
> The problem is that the backends have been public in previous releases
> and are still public in 1.7.0, It was the same state for the methods.
Yes, they were incorrectly marked as "public". It's my fault for not
removing those '@access public' tags from Richard's original code.
> The documentation shows examples usage with a direct initialization of
> Log_file: http://pear.php.net/manual/en/package.logging.log.init.phpTd«)7î
> ÏÔÅsçdü!b
I don't remember writing that, but it looks like it's been there for a
while. Directly instantiating one of the log handlers should still
work fine, so the documentation is still technically correct.
> I wonder if it's possible to release a 1.7.1 that reintroduced droped
> methods but marked as deprecated and every backends may contain a note
> about their move to a private status in the next (major?) release.
No. The Log_file class is the only one affected by this mistake, so
there's not reason to add junk to the other handlers.
If other packages really need the old behavior, they can just require
the 1.6.7 package until their code is updated to use the intended Log
API.
Because this is such an obscure case, I can't justify the additional
effort involved in doing the work to support a minimum of users who
might have been using the Log_file methods directly.
--
Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)