Re: Re: Log-1.7.0

On Thu, 18 Sep 2003 13:47:16 -0400 Jon Parise <jon@php.net> wrote: > On Thu, Sep 18, 2003 at 11:41:36AM +0200, Pierre-Alain Joye wrote: > > > However, may I recommand to set these different classes/methods as > > private for the next release and drop the direct initialization > > sample in the manual? :-D > > Those "different classes/methods" were removed in 1.7.0, which was the > catalyst for this discussion, so marking them "private" in the next > release doesn't make any sense. > > The example in the manual is still technically valid. Because PHP > isn't truly polymorphic at this level, the object instance returned by > the factory method is still a concreate instance of handler class, not > an instance of the quasi-abstract Log base class. OK. Well, my point is still the same. I understand it was a mistake to set the underlying classes as public (regardless to the php polymorphing OO crappy thingies ;) ). But once it's done, there is BC issue if you drop/change one or more methods. That has happened here and role it back seems to do no be a good thing. Then I'm in favour to the less wrost solution, document them as private. pierre