Re: [CALL FOR VOTES] File_IMC

Hi you two, Fantastic code, as usual account: cellog vote: +1 review: here goes :) I'd like to strongly encourage you not to HANDLE errors you raise, but only to raise them - let applications do the handling. This line has been blurred by PEAR_Error, but I think it is always best to let the user control error handling through PEAR::setErrorHandling(). This can only cause issues later. Incidentally, from a bug perspective, I see you have setErrorHandling() in there now, but always pass PEAR_ERROR_PRINT in Build.php, instead of the current error handling value. Also, Parse.php's _parseBlock() method needs an @access private, it's the only method you missed in your spectacular documentation frenzy :) (believe me, I approve). Incidentally, my personal opinion is that if a parameter can have only 2-3 types, you should use the types separated by | like @param string|array This may be more informative than @param mixed but that is up to you. Greg Paul M Jones wrote:

Hi, everyone, In reference to the File_IMC proposal [1] we are now calling for votes on the package. We quote the overview in [1]: "We would like to propose a new package, File_IMC, to handle parsing and building of Internet Mail Consortium files, such as vCard and vCalendar. Although Contact_Vcard exists, the original author (Paul M. Jones) is willing to deprecate it in favor of the usability gains we expect from the File_IMC package." Package: http://www.exclupen.com/misc/pear/File_IMC/File_IMC-0.2.tgz Source and examples: http://www.exclupen.com/misc/pear/File_IMC/ -- [1] http://marc.theaimsgroup.com/?l=pear-dev&m=106452596006953&w=2