Re: Re: [CALL FOR VOTES] File_IMC

Davey wrote:

acount: Davey Vote: 0 Review: code review and example review I have not voted +1 because there is one problem which you can easily fix. the build method should be like so IMNSHO: [snip]

You should check if the file_exists() before the include, rather than class_exists after so as to avoid any PHP E_NOTICE errors as you are raising your own error. You may want to do a class_exists() AS WELL after the include just to be sure its the right file or what not.

Your concerns, as well as Greg's, have been fixed in 0.3[1]. Thanks for the comments/votes. :) -- Marshall Roch http://pear.php.net/user/mroch [1] http://www.exclupen.com/misc/pear/File_IMC/