Re: [RfC] Services_Weather
| From: | Arnaud Limbourg | Date: | Fri, 03 Oct 2003 06:12:15 +0000 |
| Subject: | Re: [RfC] Services_Weather | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-22339@lists.php.net to get a copy of this message | ||
Hi,
The classes look great.
Stuff i would change
Why use multiple parameters in (Metar)
function setMetarDB($dbType, $dbUser, $dbPass, $dbHost, $dbName, $dbOptions)
{
$dsn =
$dbType."://".$dbUser.":".$dbPass."@".$dbHost."/".$dbName;
$dsninfo = array(
"phptype" => $dbType,
"username" => $dbUser,
"password" => $dbPass,
"hostspec" => $dbHost,
"database" => $dbName,
"mode" => 0644
);
when passing the dsn as a string would do the trick ?
To follow CS i would also change the return TRUE and such to lower case (true/false).
Arnaud.
> Hi folks,
>
> after the suggestions from last time I proposed Science_Weather, I redid
> the whole idea and came up with the stuff you can find at
> http://www.pc4p.net/pear/Services_Weather/
> For now I'd like to ask for a first review, there will be some stupid
> stuff in there, despite my reviews so far, so please comment or make
> suggestions, if you find something fishy.
>
> If anything goes well, I will CfV asap...