RE: [PEAR-DEV] [RFC] Do we need permission to commit WS Fixes?

> From: Davey [mailto:davey@php.net] > Sent: Friday, November 21, 2003 7:39 AM > Marshall Roch wrote: > > > Davey wrote: > > > >> I'm just curious if we need permission to commit whitespace (Tabs Vs > >> Spaces) fixes to files... any one see any reason we should seek > >> permission, no changes are made to the code itself... so nothing > >> should break. > > > > > > I think it'd be common courtesy to notify the maintainer before or just > > after you make the change. It might not be a pleasant surprise when you > > go to check out your code again and suddenly spacing is screwed up in > > your editor and you don't know why. But I'm not the one that makes > > policy, so this is, of course, just my 2 cents. > > > > Yes, I never said that contacting the maintainer shouldn't be done. But > do we need permission? This is a frequent cause of discussion on internals@. The problem is if you are working on a few things offline you end up with a potentially nasty merge once you are ready to commit because of the whitespace fix. Therefore I prefer nagging mails over just commiting. Unless the developer gives his ok. Regards, Lukas