Re: [RFC] Do we need permission to commit WS Fixes?
| From: | Stefan Neufeind | Date: | Fri, 21 Nov 2003 10:12:05 +0000 |
| Subject: | Re: [RFC] Do we need permission to commit WS Fixes? | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23788@lists.php.net to get a copy of this message | ||
On 21 Nov 2003 at 6:39, Davey wrote:
> Marshall Roch wrote:
>
> > Davey wrote:
> >
> >> I'm just curious if we need permission to commit whitespace (Tabs
> >> Vs Spaces) fixes to files... any one see any reason we should seek
> >> permission, no changes are made to the code itself... so nothing
> >> should break.
> >
> >
> > I think it'd be common courtesy to notify the maintainer before or
> > just after you make the change. It might not be a pleasant surprise
> > when you go to check out your code again and suddenly spacing is
> > screwed up in your editor and you don't know why. But I'm not the
> > one that makes policy, so this is, of course, just my 2 cents.
> >
>
> Yes, I never said that contacting the maintainer shouldn't be done.
> But do we need permission?
Simply ask the maintainer if it's okay for him if you commit those WS-
fixes - and if he agrees there's no problem at all.
Regards,
Stefan