Re: [PEPr][TEST] Proposal for XML::XML_Annotea
| From: | Martin Jansen | Date: | Sun, 30 Nov 2003 12:09:57 +0000 |
| Subject: | Re: [PEPr][TEST] Proposal for XML::XML_Annotea | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23984@lists.php.net to get a copy of this message | ||
On Sat Nov 29, 2003 at 06:5017PM -0000, PEPr wrote:
> There is a new proposal for the package XML::XML_Annotea.
> You can find more detailed information here:
> http://preview.pear.php.net/package-proposal-show.php?id=7.
Please don't use TRUE and FALSE, but true/false in your code. And method
definitions should be
function XML_Annotea_Client($server, $options = array())
{
...
}
instead of
function XML_Annotea_Client($server, $options = array()) {
...
}
And finally you are using both preg_* and ereg_* functions within the
code. Please use only one of them in order to keep the code consistent.
--
- Martin Martin Jansen
http://martinjansen.com/