Re: [PEPr] Proposal for XML::XML_FOAF

CS police. Class { function { the curly brace should be in the line under ;) NULL => null. The phpdoc comment should be just above the method they describe, there is a white line atm. I don't understand why you have

970           if (in_array($property,$common) || in_array($property,${$this->agent})) {

since it is not in a string you can write $this->agent, no need for ${this->agent}, right ? General question, when the foaf specs evolves will that mean having more methods ? If so it might make sense to have related handling in separate classes. From quickly reading the code, $foaf->person->xxx $foaf->onlineChat->xx $foaf->codepiction-> But since i hardly know foaf it may not make any sense, if so please ignore this part of the message, jsut keep the cs police :) Arnaud. PEPr wrote:

Davey Shafik (http://pear.php.net/user/davey) proposes the new package XML::XML_FOAF. You can find more detailed information here: http://preview.pear.php.net/package-proposal-show.php?id=8. Sent by PEPr Automatic proposal system at http://pear.php.net