bug in Auth 1.2.3 ?
| From: | Jeroen Houben | Date: | Fri, 16 Jan 2004 11:13:33 +0000 |
| Subject: | bug in Auth 1.2.3 ? | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25093@lists.php.net to get a copy of this message | ||
Hi,
I spotted some code in the latest Auth.php that I think contains a bug.
The FailedLoginCallback function is called *before* this bit of code:
if (!empty($this->username) && !$login_ok) {
$this->status = AUTH_WRONG_LOGIN;
}
So on a wrong login, the status is never changed because a reference to
the Auth object is passed to the function before the status is changed.
I've attached a diff from the latest CVS version (i've followed the
instructions on how to do this from the PEAR webpages).
Cheers
Jeroen