[PEPr] Comment on HTML::HTML_DataGrid
| From: | PEPr | Date: | Wed, 18 Feb 2004 21:02:57 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_DataGrid | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25698@lists.php.net to get a copy of this message | ||
Stephan Schmidt (http://pear.php.net/user/schst) has commented on the proposal for
HTML::HTML_DataGrid.
Comment:
Basically I like the package, just two small things:
1. Some methods in DataGriColumn.php need docs
2. Why is it called HTML_DataGrid when it build Excel, XML, ... shouldn't it be called
Structures_DataGrid?
3. Follow the naming conventions:
HTML/DataGrid/Column.php should contain HTML_DataGrid_Column class.
4. In your XML renderer you should use XML_Util to create the tags or replace XML entities
yourself... If you put an & in a cell your XML will not be wellformed...
Just my 2 cts.
Stephan
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=26
--
Sent by PEPr, the automatic proposal system at http://pear.php.net