RE: [PEPr] Comment on HTML::HTML_DataGrid

> -----Original Message----- > From: PEPr [mailto:pear-sys@php.net] > > Basically I like the package, just two small things: > > 1. Some methods in DataGriColumn.php need docs > > 2. Why is it called HTML_DataGrid when it build Excel, XML, ... > shouldn't it be called Structures_DataGrid? I tossed out this idea (Structures Category) before in a previous thread, but no comments. I do not know the specifics of the structures category, do you feel this is the best place for it? > > 3. Follow the naming conventions: > HTML/DataGrid/Column.php should contain HTML_DataGrid_Column class. > > 4. In your XML renderer you should use XML_Util to create the > tags or replace XML entities yourself... If you put an & in a > cell your XML will not be wellformed... > I'm in the process of this, just need to determine the correct tool to use. I will look into XML_Util. > Just my 2 cts. Thanks for your help Andrew