Re: [PEPr] +1 for Networking::Net_Cyrus

Thanks for tell me the bugs you found . I'll fix them this weekend. and add the error codes Mensaje citado por PEPr <pear-sys@php.net>: > > Greg Beaver (http://pear.php.net/user/cellog) has voted +1 on the proposal > for Networking::Net_Cyrus. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=23 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=23&handle=cellog > > This vote is conditional. The condition is: > > This is a necessary package, in my opinion. > > There are a few things that are needed. I would recommend a prominent link > to the Cyrus project in the class-level comment. > > I'm unconditional +1 if you add error codes to your use of PEAR::raiseError. > In addition, you should not call PEAR::raiseError() directly, but instead > bundle it in a method like so: > > function raiseError($msg, $code) > { > include_once 'PEAR.php'; > PEAR::raiseError($msg, $code); > } > > Some bugs: > > ($var == null) is true if $var is false or 0, use ($var === null) > > Otherwise, very nice, concise, relatively well-documented (could use a little > bit more in-depth for a few methods, but this is your prerogative, it is > clear enough) > > Greg > > -- > Sent by PEPr, the automatic proposal system at > http://pear.php.net > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > > > Saludos...damian ------------------------------------------------- Mail enviado desde el CNBA http://www.cnba.uba.ar/