[PEPr] +1 for Networking::Net_Cyrus
| From: | PEPr | Date: | Fri, 27 Feb 2004 02:10:28 +0000 |
| Subject: | [PEPr] +1 for Networking::Net_Cyrus | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25896@lists.php.net to get a copy of this message | ||
Greg Beaver (http://pear.php.net/user/cellog) has voted +1 on the proposal for
Networking::Net_Cyrus.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=23
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=23&handle=cellog
This vote is conditional. The condition is:
This is a necessary package, in my opinion.
There are a few things that are needed. I would recommend a prominent link to the Cyrus project in
the class-level comment.
I'm unconditional +1 if you add error codes to your use of PEAR::raiseError. In addition, you
should not call PEAR::raiseError() directly, but instead bundle it in a method like so:
function raiseError($msg, $code)
{
include_once 'PEAR.php';
PEAR::raiseError($msg, $code);
}
Some bugs:
($var == null) is true if $var is false or 0, use ($var === null)
Otherwise, very nice, concise, relatively well-documented (could use a little bit more in-depth for
a few methods, but this is your prerogative, it is clear enough)
Greg
--
Sent by PEPr, the automatic proposal system at http://pear.php.net