a few more Db issues
| From: | Lukas Smith | Date: | Mon, 01 Mar 2004 14:13:54 +0000 |
| Subject: | a few more Db issues | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25989@lists.php.net to get a copy of this message | ||
Hi,
1)
Ok I now figured out that modifyQuery has the portability checks inside the method. However they seem to be missing in aleast the oracle driver.
2)
Also, I saw this in the mysql driver:
/*
* Even though this DBMS already trims output, we do this because
* a field might have intentional whitespace at the end that
* gets removed by DB_PORTABILITY_RTRIM under another driver.
*/
and I think you might have gotten confused (or I am confused). MySQL does an rtrim on everything except BLOBs. So this is really redundant. Same applied to other drivers as well.
3)
Furthermore you dont silence all native API calls, which is I guess what we want to have though (since most are silenced I assume its what is wanted anyways).
4) in function mysqlRaiseError($errno = null)
you permanently add the mappings to the errorcode_map which means that they will not be unset if the option is changed at runtime.
regards,
Lukas Smith
smith@backendmedia.com
_______________________________
BackendMedia
www.backendmedia.com
berlin@backendmedia.com
Linn Zwoch Smith GbR
Pariser Str. 44
D-10707 Berlin
Tel +49 30 83 22 50 00
Fax +49 30 83 22 50 07