Re: modifyQuery()

Hi Lukas: On Mon, Mar 01, 2004 at 01:15:35PM +0100, Lukas Smith wrote: > > Also I noticed that (atleast in oracle) the 'num_fields' are set even if > no mode is set. [NB: Lukas committed these changes to tableInfo() and we discussed it on pear-doc in a thread from his commits.] > Furthermore I noticed a few little CS issues and I hope you dont mind me > fixing them. No sweat. Thanks. > I noticed that you dont make the call to modifyQuery optional and > I think it might be wise to add a portability option for that as well. On Mon, Mar 01, 2004 at 03:13:54PM +0100, Lukas Smith wrote: > > Ok I now figured out that modifyQuery has the portability checks inside > the method. However they seem to be missing in aleast the oracle driver. The modifyQuery() method in oci8 doesn't correspond to any existing portability mode. Do you think we should make one? It's probably not worth it, but I haven't fully thought about it. > and I think you might have gotten confused (or I am confused). MySQL > does an rtrim on everything except BLOBs. So this is really redundant. > Same applied to other drivers as well. You're right that MySQL does trim CHAR fields and not TEXT/BLOB/etc. Since some fields do it, the trimming is necessary for full portability. Even if every single DBMS doesn't trim BLOBS, if the portability mode is on, the blobs will get trimmed anyway in the other DBMS's, so they need to get trimmed in MySQL too. > Furthermore you dont silence all native API calls, which is I guess what > we want to have though (since most are silenced I assume its what is > wanted anyways). True. > 4) in function mysqlRaiseError($errno = null) > > you permanently add the mappings to the errorcode_map which means that > they will not be unset if the option is changed at runtime. Good point. I'll adjust that. Enjoy, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409