Re: [patch] Auth: patch allowing usage of 'custom' form fieldnames for username & password
| From: | Cipriano Groenendal | Date: | Wed, 10 Mar 2004 20:58:49 +0000 |
| Subject: | Re: [patch] Auth: patch allowing usage of 'custom' form fieldnames for username & password | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-26263@lists.php.net to get a copy of this message | ||
> I created a patch for the Auth package to support 'custom'
> form fieldnames for username & password instead of the
> fixed 'username' and 'password'
> Added 2 functions (setUsernameField and setPasswordField)
> to set the custom values if desired.
Hello :)
First of all, your patch didn't come through. Judging form your HTML mail,
you're using Outlook Express, which has a n asty little bug which means you
need to rename your patch file to .txt or it won't be accepted by the
mailing list.
Second, the change you have in your patch was recently added to the CVS
already after a patch from Michael Wallner mike@php.net, see the CVS[1] for
details of the file. This patch set those two options using the $options
array via the constructor, IIRC. However it might indeed also be a nice idea
to have setters/getters for these two fields. Thanks for your ideas and
wishing to contribute to PEAR however! I'm sure Yavor/The other Devs will
take a look at your patch and perhaps integrate the things it does better
then Mike's patch into the package :)
--
Cipriano
[1] http://cvs.php.net/diff.php/pear/Auth/Auth.php?r1=1.72&r2=1.73&ty=h