Re: [patch] Auth: patch allowing usage of 'custom' form fieldnames for username & password

Cipriano Groenendal wrote:

I created a patch for the Auth package to support 'custom' form fieldnames for username & password instead of the fixed 'username' and 'password' Added 2 functions (setUsernameField and setPasswordField) to set the custom values if desired.

Hello :) First of all, your patch didn't come through. Judging form your HTML mail, you're using Outlook Express, which has a n asty little bug which means you need to rename your patch file to .txt or it won't be accepted by the mailing list. Second, the change you have in your patch was recently added to the CVS already after a patch from Michael Wallner mike@php.net, see the CVS[1] for details of the file. This patch set those two options using the $options array via the constructor, IIRC. However it might indeed also be a nice idea to have setters/getters for these two fields. Thanks for your ideas and wishing to contribute to PEAR however! I'm sure Yavor/The other Devs will take a look at your patch and perhaps integrate the things it does better then Mike's patch into the package :)

Hi, I don't want to be nitpicking but actually it was my contribution instead of Mike's. Don't know how it got mixed up. Nevermid :D