Re: proposal for extending XML/RPC.php

On Fri Mar 12, 2004 at 10:2809AM +0100, Sebastien Person wrote: > > Please do not use HTML markup in PEAR packages: This will be a > > problem, if one wants to use XML_RPC in applications that are not > > built with HTML (like command line or Gtk applications) or that have > > to following strict style guidelines, which e.g. do not allow grey > > backgrounds. > > all the output that discover() will made must be in plain text ? Instead of generating any output, I suggest to return an associative array containing the discover()'ed information. > > Your patch does not strictly follow the PEAR coding standards, which > > are described on > > http://pear.php.net/manual/en/standards.php. This > > is quite easy to fix though. > > I have read the coding standards but I didn't well understand what isn't > compliant, if you could gave me some clue I would appreciate it and I will apply > the changing needs. > > What I have find that could be changed is listed below, please correct me if I > am wrong: > > * align assignements with spaces > * add comments conform to phpdoc convention > * change functions name to follow the studly caps style > * use _ below function name for private functions Additonally: if (foo) bar() should be changed to if (foo) { bar() } -- - Martin Martin Jansen http://martinjansen.com/