[PEPr] Comment on File Formats::File_Gettext
| From: | PEPr | Date: | Sat, 13 Mar 2004 00:37:05 +0000 |
| Subject: | [PEPr] Comment on File Formats::File_Gettext | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-26363@lists.php.net to get a copy of this message | ||
Lorenzo Alberton (http://pear.php.net/user/quipo) has commented on the proposal for File
Formats::File_Gettext.
Comment:
Great job, Michael!
Just a few pedantic notes:
- FILE Gettext.php, LINE 98 - missing ";"
- idem for FILE MO.php, LINE 236.
- in File_Gettext_MO::_read(), add a check on $bytes, it must be >0.
- add some more verbose phpdoc for important methods.
Apart from that, I'm looking forward to see this pkg in pear. I already put it in my local
repository :)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=33
--
Sent by PEPr, the automatic proposal system at http://pear.php.net