[PEPr] Comment on Text::Text_Highlight
| From: | PEPr | Date: | Mon, 05 Apr 2004 21:29:16 +0000 |
| Subject: | [PEPr] Comment on Text::Text_Highlight | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-27072@lists.php.net to get a copy of this message | ||
Jon Parise (http://pear.php.net/user/jon) has commented on the proposal for Text::Text_Highlight.
Comment:
This code doesn't follow the conding standards.
$this->highlighter is never actually used.
There's probably better ways to implement highlight() than by using that ugly eval().
In short, the code, as it stands, is a mess.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=45
--
Sent by PEPr, the automatic proposal system at http://pear.php.net