[PEPr] Comment on XML::XML_FastCreate

Stephan Schmidt (http://pear.php.net/user/schst) has commented on the proposal for XML::XML_FastCreate. Comment: Hi, basically I like the changes you made, and now the packages makes sense to me. But I'd like you to make some adjustments: 1. Error management Please use PEAR::raiseError() to trigger errors instead of implementing your own error management. 2. Drivers Please implement two different drivers for the output. You should implement a factory, like a lot of other packages do (see DB for an example). This has two advantages: If I do not need XML_Tree output, the code that has to be parsed is smaller. And your package can easily be extended by providing new drivers for DOM, simpleXML, etc. 3. XML_Util In the XML driver, that directly creates XML, please use XML_Util, which is able to build tags, comments, etc. And a wish: please provide the perl script also as PHP script. This is especially useful for Windows users, as they probably haven't Perl installed. If you could implement these changes, I think the package is great! Stephan Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=47 -- Sent by PEPr, the automatic proposal system at http://pear.php.net