Re: New package (Text_Figlet)
| From: | Tobias Schlitt | Date: | Wed, 12 May 2004 10:01:09 +0000 |
| Subject: | Re: New package (Text_Figlet) | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-29142@lists.php.net to get a copy of this message | ||
Hi Евгений
Степанищев!
You
wrote:
> Hello!
> Hi, I want to propose a package, that implements functionality of FIGlet
> (www.figlet.org).
> You can grab sources here:
> http://bolk.exler.ru/files/figlet/Text_Figlet-1.0.0.tgz
Looks pretty useless, but funny. :)
There are some cosmetic issues you'd have to fix:
- No version 1.0.0 number for the first release (please start below 1.0.0
with a beta release).
- Attribute declaration looks ugly. Please use 1 line per attribute
- Missing phpDocumentor docs. Please provide for each method and attribute.
- Use of a custom error scheme. You should use PEAR::Error when providing
errors.
Regards,
Toby
--
Tobias Schlitt
a passion for php http://www.schlitt.info