Re: [PEPr] +1 for Text::Text_Highlighter

Pepr wrote:

Bertrand Mansion (http://pear.php.net/user/mansion) has voted +1 on the proposal for Text::Text_Highlighter. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=72 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=72&handle=mansion This vote is conditional. The condition is: IMO, Some things still need to be fixed: - If end attribute is empty (end=""), generator says: Uninitialized string offset: 0 in /usr/lib/php/Text/Highlighter/Generator.php on line 242

What is the point of having an empty regexp? I think this should be considered an error. At present, the generator does not have any error checking. I believe error handling logic should be added to the generator. What do you think?

- undefined variable index line 63 (in generate tool) on every run

Will fix

- I also had some undefined index defcolor line 240 and 420 but I don't remember how (sorry...)

Hmm... I was unable to reproduce that

- In js highlighter, I think case should be set to "no"

Agree

- I still get <ol> tags in the result when using numbers=true, beside the new table with the numbers, that makes 2 cols of numbers (a bit too much ;) )

I have changed the type of 'numbers' option to integer. It can be : 0 (no numbering), HL_NUMBERS_LI (numbered list) or HL_NUMBERS_TABLE (table). Forgotten to reflect that in the docs.

Otherwise, it is working great, my Objective-C highlighter is ready.

Nice to hear that :) -- Andrey Demenev aka Blindman demenev@on-line.jar.ru