Re: Re: [PEPr] +1 for Text::Text_Highlighter

Andrey Demenev wrote: > Pepr wrote: > > > Bertrand Mansion (http://pear.php.net/user/mansion) has voted +1 on the > proposal for Text::Text_Highlighter. > > > > Proposal information: > > http://pear.php.net/pepr/pepr-proposal-show.php?id=72 > > Vote information: > > > > http://pear.php.net/pepr/pepr-vote-show.php?id=72&handle=mansion > > > > This vote is conditional. The condition is: > > > > IMO, Some things still need to be fixed: > > > > - If end attribute is empty (end=""), generator says: Uninitialized string > offset: 0 in /usr/lib/php/Text/Highlighter/Generator.php on line 242 > > What is the point of having an empty regexp? I think this should be > considered an error. At present, the generator does not have any error > checking. I believe error handling logic should be added to the > generator. What do you think? Yes, it would be nice to check if the required attributes are set and throw a PEAR_Error if not or incorrect. As you are using the generator only once, this is not a problem for performance. BTW, I haven't been able to set the generate -d option correctly (but I haven't tried really hard). About the empty end attribute, I agree with you although I think it could be replaced automatically with newline matching if not present, this way, a whole line could be matched. >> - I still get <ol> tags in the result when using numbers=true, beside the new > table with the numbers, that makes 2 cols of numbers (a bit too much ;) ) > > I have changed the type of 'numbers' option to integer. It can be : 0 > (no numbering), HL_NUMBERS_LI (numbered list) or HL_NUMBERS_TABLE > (table). Forgotten to reflect that in the docs. I overlooked the option, thanks, that's a good idea. Bertrand Mansion Mamasam