Re: #1387 [NEW]: Notice on line 195

Hallo Markus, das neue Release von Payment_DTA ist draußen, ich hoffe es klappt alles (sollte eigentlich)! Ich habe das ganze jetzt auch mit Sammelüberweisungen ausprobiert (StarMoney), es hat prima funktioniert. Danke nochmal für den Hinweis auf den Bug! Mit freundlichen Grüssen Hermann Stainer Web-Gear ------------------------------------------------------------------- Web-Gear Homepage für alle! Die eigene Homepage. Ohne Vorkenntnisse. Sofort online. E-Mail: mail@web-gear.com Support: support@web-gear.com http://www.web-gear.com/ ------------------------------------------------------------------- For the attention and use of the addressee only. No legally binding commitments will be created by this E-mail message. Where we intend to create legally binding commitments these will be made through hard copy correspondence or documents. If you are not the intended recipient of this message it may be unlawful for you to read, copy, distribute, disclose or otherwise use the information. If you are not the intended recipient, please notify us under mail@web-gear.com immediately and then destroy any electronic or paper copy of this message. =================================================================== Am Mittwoch, 12. Mai 2004 um 00:28 schrieben Sie: wa2dd> From: wolff at 21st dot de wa2dd> Operating system: FreeBSD wa2dd> PHP version: Irrelevant wa2dd> Package: Payment_DTA wa2dd> Bug description: Notice on line 195 wa2dd> Description: wa2dd> ------------ wa2dd> With error_reporting set to E_ALL, the class will throw a notice if a wa2dd> string with zero length is being passed to makeValidString(). wa2dd> This is because at the beginning of the method the string is checked if it wa2dd> has zero length - but if it hasn't, the variable never gets initialized. wa2dd> This could be fixed by initializing the variable with an empty string, but wa2dd> in case of flawed data input, this would lead to corrupt DTA files. It wa2dd> would be better if data would be checked and false would be returned from wa2dd> addExchange() in case of bad input. wa2dd> Not good: The field 'additional_name' in the parameter array for wa2dd> addExchange() is supposed to be optional - but if the string is empty, the wa2dd> notice will appear here as well. wa2dd> Expected result: wa2dd> ---------------- wa2dd> No notice :-) wa2dd> Actual result: wa2dd> -------------- wa2dd> Notice: Undefined variable: result in wa2dd> /PEAR/Payment/DTA.php on line 195 wa2dd> -- wa2dd> Edit bug report at wa2dd> http://pear.php.net/bugs/bug.php?id=1387&edit=1