Re: [PEPr] +1 for System::System_Mount
| From: | Michael Wallner | Date: | Wed, 26 May 2004 12:49:58 +0000 |
| Subject: | Re: [PEPr] +1 for System::System_Mount | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-29698@lists.php.net to get a copy of this message | ||
I wrote:
> Wouldn't it be nice if the comment would also be
> in non-conditional vote mails?
Few things more, though:
-) Please don't use *return* in the constructor.
-) Wouldn't it be better to switch to PHP5 style
__construct() instead of doing:
$pc = get_parent_class($this);
parent::$pc($entry);
which would become:
parent::__construct($entry);
Regards,
--
Michael - < mike(@)php.net >
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc