Re: Re: [PEPr] +1 for System::System_Mount
| From: | Ian Eure | Date: | Wed, 26 May 2004 18:15:57 +0000 |
| Subject: | Re: Re: [PEPr] +1 for System::System_Mount | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-29712@lists.php.net to get a copy of this message | ||
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wednesday 26 May 2004 05:49 am, Michael Wallner wrote:
> I wrote:
> > Wouldn't it be nice if the comment would also be
> > in non-conditional vote mails?
>
> Few things more, though:
>
> -) Please don't use *return* in the constructor.
>
Fixed in my CVS.
> -) Wouldn't it be better to switch to PHP5 style
> __construct() instead of doing:
>
> $pc = get_parent_class($this);
> parent::$pc($entry);
>
> which would become:
> parent::__construct($entry);
>
It sure would, but I'm not using PHP5. How does PHP5 handle a class that has
both an old-style constructor and a __construct function? I'm thinking:
class myClass
{
function __construct()
{
...
}
function myClass()
{
$this->__construct();
}
}
Would that provide both forwards- and backwards- compatibility?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFAtN7gxuUdPD6j2IMRAi79AJ9a74K79yaDnILxYsc+Rsl1VAbzkQCguj4T
fkGajQ98hiSNMlWOtSeB+TM=
=vfbc
-----END PGP SIGNATURE-----