Re: Re: [PEPr] Comment on HTML::Template_Savant

Justin Patrin wrote:

When you propose a package into PEAR you have to be aware of what came before. Even if what came before is not ideal it is important that we acknowledge the existance of what is there before and integrate the new things as much as possible.

The proposal specifically states what is different from all template systems already in PHP. This means that he did look at what came before.

Yes the proposal focuses on the differences. Ignoring the fact that Savant is just a simplified Xipe (the plugin system is a trivial feature to add to Xipe).

This is something we ask of every maintainer (as in being open to merging in new functionality) as well as the proposer (as in being to mergining in their stuff). This is a core assumption.

Again I told you right at the beginning when you started working Savant that it is essentially Xipe with one less step.

And one more. Savant has some capabilities that Xipe doesn't have. So integrating it into Xipe would make it "heavier", and that's *not* the point of Savant.

Yes what is why the should be integrated. It doesnt become heavier is you do it right. Anyways if you read what I have said closely I am mainly taking about the API here. All our template engines existed before Savant. Paul knew this. Paul was even informed about striking similarities. However he chose to implement his own API and now we have to add yet another template API to PEAR because Paul chose to ignore this? Anyways even if Paul wouldnt have been informed of this I still would have the same opinion.

It seems to be the case with Flexy as well. This is not how PEAR should work. Its nice to have a reference implementation, but now its time to integrate into PEAR.

I hope you understand the very fundamental difference between having Savant added to the template engine mix and adding a few functions to an existing one or even creating a new package that is called Foo_Lite following the API of template engine Foo which already is in PEAR.

As said before, it can't really be Foo_Lite as it both doesn't have things that other engines have and it has things that other engines don't have.

Xipe has pre and post filters. All that Savant seems to have beyond that is this plugin interface and the fact that it doesnt compile. Looking at the plugins that exist I seems more like a set of common templates you can reuse or something.

So in conclusion if we accept yet another template engine API into PEAR we might as well forget what PEAR currently stands for.

PEAR is supposed to allow for competing packages as long as they are different. Lots of people use Savant and it makes sense to me to have it as it *is* a very minimal templating engine. And as said in other comments, each of the other engines could even be extensions of Savant, which would be intereting.

And I am saying its not different. It is Xipe - minus the compile convinience feature + plus a plugin system that can easily be added to Xipe. Alan has shown how trivial it is to add something like Savant to Flexy. Need I say more? regards, Lukas Smith smith@backendmedia.com _______________________________ BackendMedia www.backendmedia.com berlin@backendmedia.com Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07