Re: GTK_ScrollingLabel Proposal
| From: | Scott Mattocks | Date: | Tue, 08 Jun 2004 12:43:40 +0000 |
| Subject: | Re: GTK_ScrollingLabel Proposal | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-30155@lists.php.net to get a copy of this message | ||
Stephan Schmidt wrote:
Hi, After a quick glance at your code, I saw that there are several undocumented methods, that *must* be documented before the package could be included in PEAR. Sorry I don't know how I missed those. The code and docs have been updated.Furthermore you should resolve some coding style
issues like true instead of TRUE and I don't understand this one. I have always thought of true and false sort of like boolean constants. Since constants should be written in all caps I always write TRUE instead of true. I will make the change and have the new code up by this time tomorrow.
function foo() { } instead of function foo() { } Sorry old habit. I'll also have this changed by tomorrow.
I never used GTK, so I'm not able to judge your code, maybe Steph or Alan will be able to say some things.... Thanks for your comments.Scott Mattocks