[PEPr] Comment on File Formats::MP3_Playlist
| From: | PEPr | Date: | Thu, 10 Jun 2004 23:46:37 +0000 |
| Subject: | [PEPr] Comment on File Formats::MP3_Playlist | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-30454@lists.php.net to get a copy of this message | ||
Daniel Convissor (http://pear.php.net/user/danielc) has commented on the proposal for File
Formats::MP3_Playlist.
Comment:
I'm looking at http://dotgeek.org/mp3_playlist/source.php?src=0.
How about cleaning up the code to meet PEAR coding standards? For example:
* The horizontal and vertical spacing of your docblocks.
* General horizontal and vertical spacing of the code in general.
Specific examples...
1) the extra space below control structure defs and method
names. Just to point to a few:
a) "if (!@$scanned) {"
b) "public function makeSmil..."
c) "public function makeSqlite..."
2) foreach should have the opening bracket on the same line
3) In "if ($this->debug == true) {" the bracket has more than
one space (or is a tab) and then the print_r() below it is
not nested correctly.
Much of this could be due to the mixed use of tabs and spaces. Please use spaces.
For an example of clean, standard docblocks, please see
http://pear.php.net/manual/en/standards.sample.php
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=87
--
Sent by PEPr, the automatic proposal system at http://pear.php.net