[PEPr] Comment on File Formats::MP3_Playlist

Stefan Neufeind (http://pear.php.net/user/neufeind) has commented on the proposal for File Formats::MP3_Playlist. Comment: The class looks fine to me - except a few things: - Imho there should be access-rights given in the docblocks for your variables - even if it were @access public, but you might maybe reevalute this as well. - maybe make...() should be to...()? Though there is no strict rule for it, but isn't this commonly used? - imho you should also implement ways to not just generate a playlist by parsing a directory but also allow to manually create a playlist, add items to it using functions, read an existing playlist from a variety of formats etc. And just for info: For the unclean MP3_ID-workaround I just filed a bug. :-) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=87 -- Sent by PEPr, the automatic proposal system at http://pear.php.net