[PEPr] Comment on File Formats::File_DNS

From: Date: Sun, 20 Jun 2004 20:58:11 +0000
Subject: [PEPr] Comment on File Formats::File_DNS
Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-30982@lists.php.net to get a copy of this message
Cipriano Groenendal (http://pear.php.net/user/cipri) has commented on the proposal for File Formats::File_DNS. Comment: > Just a side note because I recently stumbled across > the same in HTTP - the switch statement in > parseToSeconds() could be simplified to something > similar to the following: > <snip code> Hi Martin. Verry nice code, I must say. I tried it last night, and it worked fine, and I figured I'd leave it in there. Yet when I woke up this morning and saw the code, I couldn't remember where the code came from, let alone figure out how it worked. Took me two coffee's the notice the missing break;'s and seeing how it'd cascade down to seconds afterall. As such, I figured I'd best stick with the original code. Sure, it might be a few more lines, but it makes things a lot more readable :) Thanks for having a look, and your code :) Cipri Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=53 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#30982) next »