Re: DB::isError() in DB 1.6.4
| From: | Justin Patrin | Date: | Wed, 30 Jun 2004 07:53:18 +0000 |
| Subject: | Re: DB::isError() in DB 1.6.4 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-31359@lists.php.net to get a copy of this message | ||
Because you shouldn't be using such an old version of PHP maybe....?
Also, it's one call vs 3, that's a significant extra amount of
overhead.
On Wed, 30 Jun 2004 09:43:39 +0200, Benoit Delagarde
<benoit@season-of-mist.com> wrote:
>
> Hi
>
> I don't know if I'm in the right place to ask the question, but it concern
> the dev.
>
> Why DB::isError() use
> "return is_a($value, 'DB_Error');"
> instead of
> "return (is_object($value) &&
> (get_class($value) == 'db_error' ||
> is_subclass_of($value, 'db_error')));"
>
> The new version (i.e. is_a()) limit the usage to PHP 4.2.0 or higher.
> I change back to old version and it work perfectly with PHP 4.1.2
>
> So why not changing back to old version? To keep compatibility.
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
> !DSPAM:40e26d39292101621391320!
>
>
--
paperCrane --Justin Patrin--