[PEPr] +1 for File Formats::Bittorrent

From: Date: Sat, 03 Jul 2004 07:34:09 +0000
Subject: [PEPr] +1 for File Formats::Bittorrent
Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-31517@lists.php.net to get a copy of this message
Arnaud Limbourg (http://pear.php.net/user/arnaud) has voted +1 on the proposal for File Formats::Bittorrent. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=100 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=100&handle=arnaud This vote is conditional. The condition is: CS police: In the encode class: function encode_int($int) { function encode_int($int) { There is also PEAR::raiseError('File_Bittorrent_Encode()::encode() - Unsupported type.', NULL. NULL, I think you wanted to write a comma and not a dot between the two NULL statements. Which makes me realise, CS police again, that they should be lowercased null :) In the decode class I see that you use file_get_contents, which is only available since PHP 4.3. You may want to either add a dependency on PHP or suggest the use of PHP_Compat if someone is using an older php version. When untarring the archive I get this warning tar xvzf File_Bittorrent-0.1.1.tgz package.xml File_Bittorrent-0.1.1/File/Bittorrent/Encode.php File_Bittorrent-0.1.1/File/Bittorrent/Decode.php File_Bittorrent-0.1.1/example.php File_Bittorrent-0.1.1/freebsd.torrent tar: A lone zero block at 97 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#31517) next »