[PEPr] +1 for Networking::Net_HL7
| From: | PEPr | Date: | Sat, 03 Jul 2004 07:45:27 +0000 |
| Subject: | [PEPr] +1 for Networking::Net_HL7 | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-31518@lists.php.net to get a copy of this message | ||
Arnaud Limbourg (http://pear.php.net/user/arnaud) has voted +1 on the proposal for
Networking::Net_HL7.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=92
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=92&handle=arnaud
This vote is conditional. The condition is:
Some of the code is likely to break under PHP5:
ex:
It is in the Send method of Connection.php
return new Net_HL7_Response($data);
should be
$ret = new Net_HL7_Response($data);
return $ret
You may even want to add a return by reference for the method naming it &send instead of send.
I find the classes layout a bit weird, the base file containing almost nothing but as I don't
dont know HL7 I won't make suggestions which could prove off target later :)
--
Sent by PEPr, the automatic proposal system at http://pear.php.net