Re: [PEPr] +1 for Networking::Net_HL7
| From: | Justin Patrin | Date: | Sat, 03 Jul 2004 08:49:30 +0000 |
| Subject: | Re: [PEPr] +1 for Networking::Net_HL7 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-31520@lists.php.net to get a copy of this message | ||
On 3 Jul 2004 07:45:27 -0000, PEPr <pear-sys@php.net> wrote:
>
> Arnaud Limbourg (http://pear.php.net/user/arnaud) has voted +1 on the proposal for
> Networking::Net_HL7.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=92
> Vote information:
>
> http://pear.php.net/pepr/pepr-vote-show.php?id=92&handle=arnaud
>
> This vote is conditional. The condition is:
>
> Some of the code is likely to break under PHP5:
>
> ex:
> It is in the Send method of Connection.php
> return new Net_HL7_Response($data);
>
> should be
>
> $ret = new Net_HL7_Response($data);
> return $ret
It's my understanding that this has been fixed in PHP5. It was a bug.
>
> You may even want to add a return by reference for the method naming it &send instead of
> send.
>
> I find the classes layout a bit weird, the base file containing almost nothing but as I
> don't dont know HL7 I won't make suggestions which could prove off target later :)
>
> --
> Sent by PEPr, the automatic proposal system at
> http://pear.php.net
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
DB_DataObject_FormBuilder - The database at your fingertips
http://pear.php.net/package/DB_DataObject_FormBuilder
paperCrane --Justin Patrin--