[PEPr] Comment on Images::Image_Textual

Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for Images::Image_Textual. Comment: Just a couple of comments: Coding Standards: - function name() move "{" to next line - Let the code breath a little. A lot of assignment and comparison operators are jammed together. Put some spaces around them. - It's "mosaic" and not "mosiac" for the rendering mode. - For the 'mosaic': avoid putting the whole CSS declaration for each and every <div>'s. This make the result so much bigger. Create a class, for example ".PEAR_Image_Textual" and put it in a <style> tag. Also the "&nbsp;" should be avoided since it doesn't allow to precisely resize the result. <div> can be sized through CSS and provide much more flexibility (maybe an additional rendering option here.) Something like: <style> .PEAR_Image_Textual div { padding: 0px; margin: 0px; width: 5px; height: 5px; float: left; } </style> <div class="PEAR_Image_Textual"> <div style="background: #012345; clear: both;"></div> <div style="background: #6789AB"></div> </div> I let you play and find the best solution. But just make the HTML generated much smaller. Something like that could help zoom using JavaScript and DOM. -Philippe Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=113 -- Sent by PEPr, the automatic proposal system at http://pear.php.net