[PEPr] Comment on Networking::Net_NTP
| From: | PEPr | Date: | Wed, 21 Jul 2004 15:05:27 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_NTP | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-32208@lists.php.net to get a copy of this message | ||
Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for
Networking::Net_NTP.
Comment:
All of your double quoted strings should be single quoted strings as none of them need to be parsed
for variables and such.
You should also probably be using Net_Socket instead of doing direct socket manipulations.
Other than that, looks good to me.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=108
--
Sent by PEPr, the automatic proposal system at http://pear.php.net