Re: [PEPr] Comment on Images::GraPHPite

From: Date: Wed, 01 Sep 2004 11:29:57 +0000
Subject: Re: [PEPr] Comment on Images::GraPHPite
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-33143@lists.php.net to get a copy of this message
In my code (and the one available for download) I cannot find any instances of $Canvas (they should be lc first already!)
I was looking at CVS - It's alot quicker than downloading and examining.
<> As regards to named_colors.txt - shouldn't it be placed in the data folder?
It's a bit vauge here - I've never really used the data directory, for something like this, it adds unnecessary complexity, for things like .js or .html files that are need indirectly for a package, it makes sense (as you probably need to stick your data dir somewhere available to apache), but something that is tied in intrisically it's a bit messy to try and find out where the file is, then parse it.
<> If your package needs to define global variables, their name should start with a single underscore followed by the package name and another underscore. For example, the PEAR package uses a global variable called $_PEAR_destructor_object_list.
I dont think it's very clear there, you are free to use uppercase, mixed case or lowercase (I often use the trick $_GLOBALS['_'.__CLASS__] ) The name should however match the full base class name at least.
<>


« previous php.pear.dev (#33143) next »