Re: RFC Crypt_Xtea2

Hi, JD wrote:

I have recently put up a proposal for Crypt_Xtea2, which is the PHP5 version of the Crypt_Xtea class. This class has been recently fixed after a problem discovered by David Costa, which resulted in a major bugfix to handle signed/unsigned calculations properly. He also encouraged me to release a PHP5 version, so that he can use it in his class. Any feedback is more than welcome. URL: http://pear.php.net/pepr/pepr-proposal-show.php?id=147

I don't like the idea of a new package, just to be able to use it with E_STRICT. AFAICT, no other changes have been made to the code. If you encourage this, we'll have new major versions for all our packages. Don't get me wrong, I like having PHP5-only packages in PEAR, I actually proposed one last week, but I think the packages should make use of the new features. And please write public function foo() { } instead of public function foo() { } Just my 2 cts, Stephan