Re: [Patch] Use str_replace instead of preg_replace in Net_SMTP/SMTP.php
| From: | Chuck Hagenbuch | Date: | Sun, 19 Sep 2004 15:20:23 +0000 |
| Subject: | Re: [Patch] Use str_replace instead of preg_replace in Net_SMTP/SMTP.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33448@lists.php.net to get a copy of this message | ||
Quoting Matthias Pigulla <mp@webfactory.de>:
this patch will substitute two preg_replaces in SMTP.php with str_replace. That's not a big change; however, as all data sent passes through these calls, it makes a performance difference - at least for me ;)I've committed the comma-doubling change - thanks. However, I need someone to indulge my lack of testing time at the moment and convince me that the first change really does what it's supposed to do and won't miss things/double newlines/etc. Thanks, -chuck -- "But she goes not abroad in search of monsters to destroy." - John Quincy Adams