[PEPr] Comment on System::System_Serial
| From: | Stephan Schmidt | Date: | Fri, 24 Sep 2004 07:54:15 +0000 |
| Subject: | [PEPr] Comment on System::System_Serial | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33527@lists.php.net to get a copy of this message | ||
Stephan Schmidt (http://pear.php.net/user/schst) has commented on the proposal for
System::System_Serial.
Comment:
Hi,
1. You seem to have some indentation problems (are you using tabs?)
2. Please remove all methods that you marked with @ignore
3. Please change System_Serial_Win32COMconnection::newConnection() to
System_Serial_Win32COMconnection::singleton()
4. Please consider providing a PHP4 version. Except visibility you are not
using any PHP5-specific features
5. Please follow the coding standards:
if (!$result) $this->_initialized = TRUE;
should be
if (!$result) {
....
}
Stephan
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=149
--
Sent by PEPr, the automatic proposal system at http://pear.php.net