[PEPr] Comment on Search::Search_Mnogosearch
| From: | Mika Tuupola | Date: | Mon, 18 Oct 2004 13:20:19 +0000 |
| Subject: | [PEPr] Comment on Search::Search_Mnogosearch | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33931@lists.php.net to get a copy of this message | ||
Mika Tuupola (http://pear.php.net/user/tuupola) has commented on the proposal for
Search::Search_Mnogosearch.
Comment:
Some points found out strolling through the code.
* Since constructor can't and should not return anything else but itself
everything from Search_Mnogosearch() should be moved to connect(), then
you can actually return the PEAR_Error on error.
Otherwise I think it looks ok. Will test the code later.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=166
--
Sent by PEPr, the automatic proposal system at http://pear.php.net