Re: [PEPr] +1 for Search::Search_Mnogosearch

On Sat, 2004-11-27 at 12:02, Gerrit Goetsch wrote: > Helgi Þormar wrote: > > Helgi Þormar (http://pear.php.net/user/dufuz) has voted +1 on the proposal for > > Search::Search_Mnogosearch. > > > > Proposal information: > > http://pear.php.net/pepr/pepr-proposal-show.php?id=166 > > Vote information: > > > > http://pear.php.net/pepr/pepr-vote-show.php?id=166&handle=dufuz > > > > This vote is conditional. The condition is: > > > > - Fix CS issues, array (), isset () and such. > no problem. Great :) > > - Move the result class into it's own file if possible. > also, no problem. Also great. > > - Where's Pager used ? can't see anything about that > The Pager is used by the Sigma renderer class. Take a look at the linked > package file in the class "Search_Mnogosearch_Renderer_Sigma". Ahh okey, I used looked at the .phps file you provided in the proposal, see it now when I use the show source link on the examples :) Nice. > > Optional Conditional: > > - Support for more renders then Sigma (well will probably rather come from contributes) > Why not! Feel free to join and implement more renderes. I'll maybe look into that if I have time ;) Also just a little tip, I'd recommend you release this in the alpha state, and use that state for maybe few releases to have the option to do API changes if needed, I'm looking forward to test this package in near future. Regards Helgi