[PEPr] Comment on Gtk Components::Gtk_FileDrop

From: Date: Wed, 20 Oct 2004 19:39:45 +0000
Subject: [PEPr] Comment on Gtk Components::Gtk_FileDrop
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-34007@lists.php.net to get a copy of this message
Scott Mattocks (http://pear.php.net/user/scottmattocks) has commented on the proposal for Gtk Components::Gtk_FileDrop. Comment: - The file should be FileDrop.php (The classname should stay the way it is though.) - Would it be possible to let users set the extensions in getMimeType? In getMimeType you check file extensions but what if I only want to allow rss xml files to be droped? Just checking mime type for xml might not be enough. I might want to say that only files that end in .rss can be dropped. - Not such a big point, but if there is any situation where MIME_Type is not used you might want to consider moving the require call down until it is needed. It will prevent you from adding lots of unneeded code. Other than that, nice job. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=167 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#34007) next »