Re: nestedset
| From: | Daniel Khan | Date: | Tue, 30 Nov 2004 14:15:20 +0000 |
| Subject: | Re: nestedset | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-34661@lists.php.net to get a copy of this message | ||
Hello Lukas,
Lukas Smith wrote:
[..]
Yes you are totally right. Using the PEAR destructor doesn't make sense at all. But DB_NestedSet isn't a subclass of PEAR anymore. The PEAR constructor also isn't called within it's constructor. So the destructor method '_DB_NestedSet' is must have been somehow leftover and should never be called. (Correct me if I am wrong.) I'll remove this with the next release. Thanks for the hint. [..]I am really not sure if the use of the PEAR destructor makes sense for this class. Remember that the pear desctructors are only called right before shutdown.
ah one more things .. the way the calls are implemented to the database backend makes it overly hard to write a driver for a backend that has different method names. [..]There were good reasons why I did it exactly this way. But I can't remember which :) So maybe you are right... I have to rethink it as soon I have some spare time. For upcoming major releases this part will be fully refactured. greetings -- Daniel Khan