Re: Re: PEAR::File package maintainance request
| From: | Pierre-Alain Joye | Date: | Wed, 01 Dec 2004 14:31:18 +0000 |
| Subject: | Re: Re: PEAR::File package maintainance request | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-34691@lists.php.net to get a copy of this message | ||
On Wed, 01 Dec 2004 15:22:27 +0100
lsmith@php.net (Lukas Smith) wrote:
> Pierre-Alain Joye wrote:
> > On Wed, 1 Dec 2004 04:21:35 -0800
> > ieure@php.net (Ian Eure) wrote:
> >
> >
> >>On Wednesday 01 December 2004 04:06 am, Michael Wallner wrote:
> >>
> >>>I'm also not sure whether File::readAll()
> >>>should use file_get_contents() if it's available...
> >>>
> >>
> >>Is a dependency on PHP_Compat out of the question?
> >
> >
> > Adding such dep only for file_get_contents sounds bad to me.
> > file_get_content exists already , just make a test
> > in File::readAll sounds much better to me.
>
> well make it an optional dep ..
Miss the point :). Do not have this dep at all is better. Especially
for such feature (feature which already exists in the class File::).
a quick if function_exists solve this problem.
--Pierre