[PEPr] Comment on Web Services::Service_Geo

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for Web Services::Service_Geo. Comment: Wonderful package, I'm sure this is going to be very useful. Some comments on your code: - Please add @access for any member vars which are private / protected. These vars should also have a _ prepended to their names (did we come to the conclusion that this was needed for just private or private and protected...?) - Technically, according to CS, the opening brace of a function should be on a line by itself and indeted the same as the 'function' keyword - Geo.php seems to have an extra newline after the ?> - there should be a space between the class name and the opening brace - there should be a space between the ) of a function delaration and the opening brace (RequestHander/WMS.php) - if( should be if (, foreach( should be foreach ( (etc.) (Exception.php, VersionHandler.php) (Optional) multiline comment blocks should have the lines other than the first have their * line up with the first * in the first line Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=195 -- Sent by PEPr, the automatic proposal system at http://pear.php.net