[PEPr] Comment on Web Services::Service_Geo

bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for Web Services::Service_Geo. Comment: It exists certainly a big demand for such a package. Anyway, as you intend to do, PEAR should offer a general class which can be implemented for various suppliers. I would say your OO structure is well done. Just, perhaps the properties are too much oriented to this first service you implement and not well placed in classes. Some properties only belong to the request handler (from a first glance, perhaps I'm wrong) Anycase the basic properties init is very confused, defaults should be isolated. This parameter initialization is not flexible enough for any extension to other suppliers. I would suggest you to take a look in package Net_SMS which have to solve the same kind of generalization goal. Marko's solution is somewhat opaque but is really open for future extensions. You could approach such structure, just extracting what is basically general. Don't take it bad, as said, I think the structure as a whole is OK. -- bertrand Gugger (toggg) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=195 -- Sent by PEPr, the automatic proposal system at http://pear.php.net